Skip to content

Remove outdated code and unnecessary captureRenderTree patching #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove outdated code and unnecessary captureRenderTree patching #2498

merged 1 commit into from
Mar 11, 2024

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Nov 7, 2023 •
edited
Loading

  • remove outdated code, patched capture render tree is not needed anymore, its already in the locked ember version
  • move Ember.x usages to requires (only left is Ember.Libraries, there is no import for it...)

patricklx
patricklx commented Nov 7, 2023
View reviewed changes
ember_debug/utils/type-check.js Outdated
@@ -13,17 +12,6 @@ export function isComputed(object, key) {
if (Debug.isComputed && Debug.isComputed(object, key)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ember > 3.10

@patricklx patricklx marked this pull request as draft November 7, 2023 13:34
@patricklx patricklx force-pushed the cleanup-old branch 5 times, most recently from 2580470 to 2f1a917 Compare March 1, 2024 12:43
@patricklx patricklx marked this pull request as ready for review March 1, 2024 12:46
@patricklx patricklx force-pushed the cleanup-old branch 2 times, most recently from aefdbb5 to 8a58e53 Compare March 1, 2024 15:34
@RobbieTheWagner RobbieTheWagner changed the title cleanup Remove outdated code and unnecessary captureRenderTree patching Mar 11, 2024
@RobbieTheWagner RobbieTheWagner merged commit 7a24819 into emberjs:main Mar 11, 2024
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricklx @RobbieTheWagner